[PATCH] Fifteen puzzle config revamp

[Andre Magalhaes]

2008/1/22 Chani <chanika at gmail.com>:
>
> +    while (m_pieces.at(rand) != NULL) {
> +      rand = qrand() % 16;
> +    }
>
> this... looks... Bad.
> I hate seeing any loop that has a random ending condition... what if it never
> finishes?
> but I don't know the context, and it's past my bedtime so I'm just gonna skip
> down to... oh! you already used configNeedsSaving() - awesome. :)
>
Yeah, I don't like this also, but this is not my code, and I didn't
touch it (besides
reindent it).
I tried to just fix the config dialog, and add the possibility to save
the config options.
Maybe this can be discussed with the applet "owner".

BR

-- 
Andre Moreira Magalhaes (andrunko)
--------------------------------------------------------
Jabber: andrunko at gmail.com
MSN:   andremoreira at msn.com
Skype:  andrunko
Blog:    http://andrunko.blogspot.com