[PATCH] Fifteen puzzle config revamp

Chani chanika at gmail.com
Tue Jan 22 20:27:39 CET 2008


+    while (m_pieces.at(rand) != NULL) {
+      rand = qrand() % 16;
+    }

this... looks... Bad.
I hate seeing any loop that has a random ending condition... what if it never 
finishes?
but I don't know the context, and it's past my bedtime so I'm just gonna skip 
down to... oh! you already used configNeedsSaving() - awesome. :)

-- 
This message brought to you by evyl bananas, and the number 3.
www.chani3.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080123/f640f08e/attachment.pgp 


More information about the Panel-devel mailing list