[PATCH] Fifteen puzzle config revamp

Andre Magalhaes andrunko at gmail.com
Tue Jan 22 20:03:19 CET 2008


Hi all,

Here I am again. I am trying to get the config dialogs in a sane state.
Another config dialog that was pissing me off was the Fifteen puzzle
config dialog
so I rewrote it.

The code now besides the visual improvement, saves config options,
so when you reload the applet it will use the saved options.
I also reindented some part of the code to follow the applets code indentation

Eg.: Added {  } to all if, while, for ...
       Removed trailing whitespaces
       ...

Here are the screenshots of the old and new config dialog:

Old config in the initial state:
http://www.flickr.com/photos/andrunko/2212773400/
Old config when "Split ..." option is selected:
http://www.flickr.com/photos/andrunko/2212773404/
Old config when "Plain .." option is selected again:
http://www.flickr.com/photos/andrunko/2212773406/

New config in the initial state:
http://www.flickr.com/photos/andrunko/2212773410/
New config when "Split ..." option is selected:
http://www.flickr.com/photos/andrunko/2212773414/

I  also added an action in the menu to shuffle the pieces.

There is only one remaining issue in the new config dialog. I don't think
a shuffle pieces button should be there, but I can't find a way to do
it but in the menu (already added in the patch).

Any feedback is welcome, if everybody agrees I will commit it.

BR

-- 
Andre Moreira Magalhaes (andrunko)
--------------------------------------------------------
Jabber: andrunko at gmail.com
MSN:   andremoreira at msn.com
Skype:  andrunko
Blog:    http://andrunko.blogspot.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kde4_plasma_applet_fifteen_puzzle.diff
Type: text/x-diff
Size: 25091 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080122/cea0dd2f/attachment-0001.bin 


More information about the Panel-devel mailing list