[PATCH] Tooltip alignment (and all the other popups too)

[Marco Martin]

On Monday 21 January 2008 22:42:11 Aaron J. Seigo wrote:
> On Monday 21 January 2008, Marco Martin wrote:
> > On Monday 21 January 2008, Aaron J. Seigo wrote:
> > > On Monday 21 January 2008, Marco Martin wrote:
> > > > can i start to change the applets that uses popup menus to use
> > > > popupPosition()?
> > >
> > > please do, yes! =)
> >
> > i see Plasma::Dialog::position does a similar thing, should it be
> > removed? or the code in popupPosition be put here? i think if the code is
> > in widget is nicer because it can work with everything and not only
> > Plasma::dialog
>
> agreed; less code dupe is good. we should have this in one place. if
> Plasma::Dialog can't comfortably use the code in Plasma::Widget, then
> perhaps we need to create a method in plasma.h that does the actual
> calculation based on orientation and size, and have
> Plasma::Widget::popupPosition()
> automatically pass in the orientation, etc to that method.
>
> iow, exactly like i did in kicker =)

at the moment it's the applet that calls widget->popupPosition(size of the 
dialog)
so there should not be problems, apart the new device notifier that don't know 
why it uses a normal kicon instead of a plasma icon in the applet but should 
not be hard to change this
the only thing is i'm really hesitant to kill a public function in a class :)

Cheers,
Marco Martin