[PATCH] Tooltip alignment (and all the other popups too)

Aaron J. Seigo aseigo at kde.org
Mon Jan 21 22:42:11 CET 2008


On Monday 21 January 2008, Marco Martin wrote:
> On Monday 21 January 2008, Aaron J. Seigo wrote:
> > On Monday 21 January 2008, Marco Martin wrote:
> > > can i start to change the applets that uses popup menus to use
> > > popupPosition()?
> >
> > please do, yes! =)
>
> i see Plasma::Dialog::position does a similar thing, should it be removed?
> or the code in popupPosition be put here? i think if the code is in widget
> is nicer because it can work with everything and not only Plasma::dialog

agreed; less code dupe is good. we should have this in one place. if 
Plasma::Dialog can't comfortably use the code in Plasma::Widget, then perhaps 
we need to create a method in plasma.h that does the actual calculation based 
on orientation and size, and have Plasma::Widget::popupPosition() 
automatically pass in the orientation, etc to that method.

iow, exactly like i did in kicker =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080121/4b6175e7/attachment.pgp 


More information about the Panel-devel mailing list