[PATCH] Several rows in taskbar

[Chani]

On January 20, 2008 21:18:09 Olivier Goffart wrote:
> Le dimanche 20 janvier 2008, Marco Martin a écrit :
> > On Saturday 19 January 2008 10:19:52 Olivier Goffart wrote:
> > > Hi,
> > >
> > > The patch add the support for showing taskbar entry in several rows
> > > (with all the animations ans stuff)
> > > When there is too much task shown in the taskbar, it automatically take
> > > more rows.
> >
> > Hi,
> > seems neat, only a couple of doubts:
> > like Chani said i would have gone with a grid layout,
>
> Definitively not a grid layout.
> In a grid layout you insert item at a certain position on the grid (you
> give the col and the row number, and eventually the item can take several
> position of the grid)
> But for this feature, you just insert items in the list, this is exactly
> the way box layouts works.

I agree, it looks like using a gridlayout would mean frequently changing the 
number of rows. this way does look easier, I just can't shake the feeling 
that there's some reason not to o it.

> I originaly wanted to subclass the BoxLayout for this feature, but it would
> just have created more code duplication.

yeah, this was my first thought. :/


> Ah yes, that should be fixed.   Anyway, if this happen, that mean you have
> so much task that the width of the entry is very small and only the first
> letter can be read

that'll happen less often when we have window grouping :)

>
> > vertical panels, where the tasks are put in a column(yeah, not supported
> > at the moment) this patch should be deactivated in this case

I wonder - if we simply flipped the boxlayout direction, would anything really 
break? :)
I guess we'll find out once the panel can be easily moved around.

>
> Not necesserly.   This would work fine with vertical panel also.  (But
> instead of taking severals rows, it will take several columns.

although there are different things to consider with a vertical panel. not 
much horizontal space for the text to begin with - would anyone really *want* 
more than one column?


> Btw, what's the status of libplasma regarding binary compatibility?

I don't think binary compatibility is expected at all for 4.1, seeing as we're 
getting widgets-on-canvas n'stuff.
for 4.0.x I'm assuming the regular rules apply. of course, aaron's the one who 
actually knows these things for sure :)

-- 
This message brought to you by evyl bananas, and the number 3.
www.chani3.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080120/423a2f89/attachment.pgp