locations runner lowercases the path part of urls. proposed patch included.

Aaron J. Seigo aseigo at kde.org
Sun Jan 13 00:29:15 CET 2008


On Saturday 12 January 2008, Frode M. Døving wrote:
> After some investigation i found that the locations runner lowercases the
> search terms. First the search->searchTerm() is lowercased into a QString
> named term. I removed the .toLower(), not sure what that might break, if
> anything?

it will break any runners that expect it to be lower case, yes. =) but this 
can probably be found fairly easily by looking at each runner's current 
match() method. having just done so it seems that all the runners that need 
to are handling case insensitivity on their own properly now, so ... this 
should be fine to commit and given the url use case is the correct thing to 
do.

> Also QUrl::setHost() is used to set the host+path, which again lowercases
> the complete string. I changed that to two operations. As shown in the
> attached diff.

hm.. yes, this is indeed better for that case if it messes with the casing. 

please commit.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080112/c33f133b/attachment.pgp 


More information about the Panel-devel mailing list