No Wallpaper patch

[Cody]

On Thursday 10 January 2008 03:58:32 am Alex Merry wrote:
> At Wednesday 09 January 2008 23:56, you wrote:
> > this enables the option "No Wallpaper" in the Configure Desktop dialog.
> > Preview for no wallpaper isn't working.  I haven't figured out why yet..
> > Here's the patch.
>
> Excellent!  Just a few comments:
>
> Why do you need the drawImage bool in setPreview/the render() call?  Why
> not just check for an empty QString for the image in render()?
>
> +        config.writeEntry("wallpaper", "");
>
> This should be QString(), rather than "" (efficiency, and clearer typing).
>
> Also, for clarity, you could merge the kNoBackground and kStaticBackground
> cases in changeBackgroundMode().
>
> With the attached patch (which is yours with the above points fixed),
> preview works for me when you change the wallpaper mode, but not when you
> change colour.
>
> To update on colour change, you need to listen to the relevant signal from
> the colour widget.
>
> You should also make the picture and positioning widgets disappear when
> selecting "None".
>
> Alex

OK, after applying your changes here's whats in this one:

Disables the picture and positioning drop down boxes and put the stackedWidget 
on the right page when "None" is selected.  Preview is also fixed.  

Thanks,
Cody
-------------- next part --------------
A non-text attachment was scrubbed...
Name: desktop-nobackground.diff
Type: text/x-diff
Size: 5715 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080110/740bc3c9/attachment-0001.bin