[Panel-devel] Icon Layouts

[Christopher Blauvelt]

On Jan 2, 2008 10:29 PM, Christopher Blauvelt <cblauvelt at gmail.com> wrote:

>
>
> On Jan 2, 2008 10:03 AM, Aaron J. Seigo <aseigo at kde.org> wrote:
>
> > On Wednesday 02 January 2008, Christopher Blauvelt wrote:
> > > On Jan 1, 2008 11:38 PM, Aaron J. Seigo <aseigo at kde.org> wrote:
> > > > On Tuesday 01 January 2008, Christopher Blauvelt wrote:
> > > > > Attached is a patch that allows you to align icons to a grid.
> >  Further,
> > > >
> > > > it
> > > >
> > > > * there is a write- and readEntry in KConfigGroup that takes a
> > QPointF.
> > > > you
> > > > don't need to do the parsing yourself (indeed, shouldn't)
> > >
> > > I'm not following which code segment you're talking about.
> >
> > the inline readPos and writePos methods.
> >
> > it's unfortunate you even have to store/restore those and can't just let
> > the
> > usual applet loading handle it for you ... but oh well =)
> >
> > > > immutability and locking of the containment; Show Icons should go
> > into
> > > > the config dialog, not the context menu;
> > >
> > > I would have liked to make a submenu to address icons but I couldn't
> > see
> > > how that was possible given that only QAction*'s can be returned from
> > > contextMenu().
> >
> > this is something i'd like to find an elegant solution to for 4.1. one
> > that
> > doesn't involve returning QMenus, either ;)
> >
> > > I remove Icon related items when they're not shown but if
> > > it needs to be added to the config dialog I can add the extra tab that
> > had
> > > been previously discussed.  Unless you had a different proposal.
> >
> > well, i don't think we need a tab for just 2 checkboxes. they can simply
> > be
> > added to the bottom of the dialog imho.
> >
> > > > +    if (iconsVisible) {
> > > > +        m_desktopDir.openUrl(KGlobalSettings::desktopPath());
> > > > +    }
> > > > +    else {
> > > >
> > > > ;)
> > >
> > > Man, you're worse than my sixth-grade english teacher :)  Fixed.
> >
> > yeah, i know. just imagine being me though and cringing every time i
> > spot one
> > of these issues thinking, "oh man, they are going to think i'm the most
> > horribly OCD person in the WORLD!". i just want a clean code base and am
> > trying to instill those values into the project. honestly, i don't
> > alphabetize my sock drawer or anything like that in real life ;)
> >
> > > > * do we need to offer a separate hook for media icons? hm.. i
> > suppose so
> > > > if
> > > > only because someone might want
> > >
> > > That's next to be implemented.
> >
> > cool.
> >
> > > > * i assume the icon.h and icon.cpp bits aren't intended as part of
> > the
> > > > diff?
> > >
> > > Oops!  Thats a start at my attempt to allow dragging of icons by
> > clicking
> > > and dragging from the middle.  I guess I need to do an "svn diff" from
> > a
> > > little farther down in the directory.
> >
> > ;) yeah, i often end up having to specify the exact files when doing
> > diffs
> > myself. oh well =)
> >
> > --
> > Aaron J. Seigo
> > humru othro a kohnu se
> > GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
> >
> > KDE core developer sponsored by Trolltech
> >
> > _______________________________________________
> > Panel-devel mailing list
> > Panel-devel at kde.org
> > https://mail.kde.org/mailman/listinfo/panel-devel
> >
> > Attached is the a patch with changes to include:
> - Removed the "lock icons" feature
> - Fixed Style violations
> - Removed the readPos and writePos methods since they weren't used anyway.
>
>
> Just wondering if anybody had taken a look at this to see if  it was good
to commit.  I just want to make sure I meet the deadline.
Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/panel-devel/attachments/20080103/9ed5ee66/attachment-0001.html