<br><br><div class="gmail_quote">On Jan 2, 2008 10:29 PM, Christopher Blauvelt <<a href="mailto:cblauvelt@gmail.com">cblauvelt@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br><br><div class="gmail_quote"><div><div></div><div class="Wj3C7c">On Jan 2, 2008 10:03 AM, Aaron J. Seigo <<a href="mailto:aseigo@kde.org" target="_blank">aseigo@kde.org</a>> wrote:<br></div></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><div></div><div class="Wj3C7c">
<div>On Wednesday 02 January 2008, Christopher Blauvelt wrote:<br>> On Jan 1, 2008 11:38 PM, Aaron J. Seigo <<a href="mailto:aseigo@kde.org" target="_blank">aseigo@kde.org</a>> wrote:<br>> > On Tuesday 01 January 2008, Christopher Blauvelt wrote:
<br>> > > Attached is a patch that allows you to align icons to a grid. Further,<br>> ><br>> > it<br>> ><br>> > * there is a write- and readEntry in KConfigGroup that takes a QPointF.<br>
> > you<br>> > don't need to do the parsing yourself (indeed, shouldn't)<br>><br>> I'm not following which code segment you're talking about.<br><br></div>the inline readPos and writePos methods.
<br><br>it's unfortunate you even have to store/restore those and can't just let the<br>usual applet loading handle it for you ... but oh well =)<br><div><br>> > immutability and locking of the containment; Show Icons should go into
<br>> > the config dialog, not the context menu;<br>><br>> I would have liked to make a submenu to address icons but I couldn't see<br>> how that was possible given that only QAction*'s can be returned from
<br>> contextMenu().<br><br></div>this is something i'd like to find an elegant solution to for 4.1. one that<br>doesn't involve returning QMenus, either ;)<br><div><br>> I remove Icon related items when they're not shown but if
<br>> it needs to be added to the config dialog I can add the extra tab that had<br>> been previously discussed. Unless you had a different proposal.<br><br></div>well, i don't think we need a tab for just 2 checkboxes. they can simply be
<br>added to the bottom of the dialog imho.<br><div><br>> > + if (iconsVisible) {<br>> > + m_desktopDir.openUrl(KGlobalSettings::desktopPath());<br>> > + }<br>> > + else {
<br>> ><br>> > ;)<br>><br>> Man, you're worse than my sixth-grade english teacher :) Fixed.<br><br></div>yeah, i know. just imagine being me though and cringing every time i spot one<br>of these issues thinking, "oh man, they are going to think i'm the most
<br>horribly OCD person in the WORLD!". i just want a clean code base and am<br>trying to instill those values into the project. honestly, i don't<br>alphabetize my sock drawer or anything like that in real life ;)
<br><div><br>> > * do we need to offer a separate hook for media icons? hm.. i suppose so<br>> > if<br>> > only because someone might want<br>><br>> That's next to be implemented.
<br><br></div>cool.<br><div><br>> > * i assume the icon.h and icon.cpp bits aren't intended as part of the<br>> > diff?<br>><br>> Oops! Thats a start at my attempt to allow dragging of icons by clicking
<br>> and dragging from the middle. I guess I need to do an "svn diff" from a<br>> little farther down in the directory.<br><br></div>;) yeah, i often end up having to specify the exact files when doing diffs
<br>myself. oh well =)<br><font color="#888888"><br>--<br></font><div><div></div><div>Aaron J. Seigo<br>humru othro a kohnu se<br>GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43<br><br>KDE core developer sponsored by Trolltech
<br></div></div><br></div></div><div class="Ih2E3d">_______________________________________________<br>Panel-devel mailing list<br><a href="mailto:Panel-devel@kde.org" target="_blank">Panel-devel@kde.org</a><br><a href="https://mail.kde.org/mailman/listinfo/panel-devel" target="_blank">
https://mail.kde.org/mailman/listinfo/panel-devel</a><br><br></div></blockquote></div>Attached is the a patch with changes to include:<br>- Removed the "lock icons" feature<br>- Fixed Style violations<br>- Removed the readPos and writePos methods since they weren't used anyway.
<br><br>
</blockquote></div>Just wondering if anybody had taken a look at this to see if it was good to commit. I just want to make sure I meet the deadline.<br>Chris<br>