[PATCH] Pretty rectangles around the icons

[Marco Martin]

On Thursday 03 January 2008, Aaron J. Seigo wrote:
> On Wednesday 02 January 2008, Marco Martin wrote:
> > this patch adjust the radius of the background rectangle of the icons,
> > and it does not uses the svg anymore.
> > The svg is still used for the icon actions background and in
> > drawForeground() (even if the foreground-hover and foreground-pressed
> > elements are empty at the moment, not had decent ideas for it :D)
>
> you may as well ditch the svg completely then. no point in the overhead if
> we aren't using it for the background. it's a very basic svg in there right
> now anyways, and even if this does completely and absolutely screw the idea
> of making plasma themable, hopefully we can fix it after 4.0.

ok, here is my take: at the moment still leave the svg here and provide a svg 
with only action buttons background, so there shouldn't be much overhead, 
because drawbackground doesn't use the svg and drawforeground shouldn't 
execute at all because svgElements won't have SvgForeground and the others.

at the moment i've started to work on a Svg subclass called BorderedSvg (yeah, 
should come up with a less idiot name :P) that should abstract the way of 
painting background of standardBackground of the applets (at this point of 
course for 4.1)
so i would leave the remains of the svg in the icon otherwise more or less the 
same things should be removed and added again :)

> again, because we don't really have much of any artist time being spent on
> plasma. i was hoping there would be some attention paid to it, but ..
> whatever. i'm not a graphic artist, so you can blame me for the lack of
> time spent picking colours if you wish. the file that's there is an old
> version of the oxygen colour scheme with a very basic tweak for the
> foreground. and yes, feel free to change the background to something that
> matches the background of the applet background; which would be, looking at
> it in inkscape, black =)

ok, done

Cheers,
Marco Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: icon_roundrect2.diff
Type: text/x-diff
Size: 12656 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080103/3e413e8d/attachment.bin