[PATCH] Pretty rectangles around the icons

[Aaron J. Seigo]

On Wednesday 02 January 2008, Marco Martin wrote:
> this patch adjust the radius of the background rectangle of the icons, and
> it does not uses the svg anymore.
> The svg is still used for the icon actions background and in
> drawForeground() (even if the foreground-hover and foreground-pressed
> elements are empty at the moment, not had decent ideas for it :D)

you may as well ditch the svg completely then. no point in the overhead if we 
aren't using it for the background. it's a very basic svg in there right now 
anyways, and even if this does completely and absolutely screw the idea of 
making plasma themable, hopefully we can fix it after 4.0.

> drawBackground() draws a Plasma::roundedRectangle(), at the moment it's
> white or black depending by the value of
> KColorScheme(QPalette::Active, KColorScheme::Window,
> Plasma::Theme::self()->colors()).foreground().color()
> because i didn't find two good contrasting colors
> i wonder why in the colors configuration file [Colors:Window] has
> ForegroundNormal=255,255,255   and   BackgroundNormal=241,241,241  it not
> makes a good contrast, shouldn't be BackgroundNormal=0,0,0 or something
> like that?
> how does it look like?

again, because we don't really have much of any artist time being spent on 
plasma. i was hoping there would be some attention paid to it, but .. 
whatever. i'm not a graphic artist, so you can blame me for the lack of time 
spent picking colours if you wish. the file that's there is an old version of 
the oxygen colour scheme with a very basic tweak for the foreground. and yes, 
feel free to change the background to something that matches the background 
of the applet background; which would be, looking at it in inkscape, black =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080102/29914a0a/attachment.pgp