Review Request: properly remove m_size var from panel code

[Chani Armitage]

> On 2008-02-29 09:42:07, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp, line 388
> > <http://mattr.info/r/219/diff/2/#file692line388>
> >
> >     Plasma::Floating is another valid possibility

in the future, but I have no idea how to handle such a thing, so I try to just do nothing


> On 2008-02-29 09:42:07, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp, line 422
> > <http://mattr.info/r/219/diff/2/#file692line422>
> >
> >     i'm not sure what this method is supposed to be doing? it's obviously broken for multiscreen, but beyond that why is it setting the x/y for right/bottom?

yeah, this is confusing. it used to set the x,y of the panel... then I discovered that I didn't really need to set such a thing: it's the view that needs to move, not the containment. but then I discovered that the view only updates properly if some kind of geometry change happens, so I reduced it to a simple hack. I should add a reminder to clean it up somehow...

for the sake of multiple panels, maybe the containment *should* move itself anyways. I'm not quite sure how we're planning to arrange multiple panel containments on the corona such that they don't overlap.


> On 2008-02-29 09:42:07, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp, lines 442-443
> > <http://mattr.info/r/219/diff/2/#file692line442>
> >
> >     that's a bit of an odd comment since the first thing setGeometry does is call setPos.
> >     
> >     in what way was it confusing the view?
> >     
> >     was the size() changing as well in this process?

by "confuses" I mean "the view doesn't notice anything has changed". no, size() was not changing.
/me looks at the setGeometry code...
oh, it must be that update() down at the bottom. maybe I just need to call that, really, instead of all this updatePos insanity. er, but I have a feeling I'm not really supposed to call update() from constraintsUpdated() - why do I have that feeling?


- Chani


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/219/#review216
-----------------------------------------------------------


On 2008-02-29 10:49:39, Chani Armitage wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/219/
> -----------------------------------------------------------
> 
> (Updated 2008-02-29 10:49:39)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> this completely removes m_size. I introduced a few functions to keep things clear. there is a small change in behaviour - the config dialog now shows the full size of the panel, including the borders.
> this might horribly break with multiple screens, I'm not sure. please test.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.h
>   /trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp
> 
> Diff: http://mattr.info/r/219/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chani
> 
>