Review Request: properly remove m_size var from panel code

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/219/#review216
-----------------------------------------------------------



/trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp
<http://mattr.info/r/219/#comment167>

    i think you can remove the "maybe we should" from the TODO since we really ought to do this at some point.



/trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp
<http://mattr.info/r/219/#comment165>

    Plasma::Floating is another valid possibility



/trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp
<http://mattr.info/r/219/#comment168>

    i'm not sure what this method is supposed to be doing? it's obviously broken for multiscreen, but beyond that why is it setting the x/y for right/bottom?



/trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp
<http://mattr.info/r/219/#comment169>

    that's a bit of an odd comment since the first thing setGeometry does is call setPos.
    
    in what way was it confusing the view?
    
    was the size() changing as well in this process?


- Aaron


On 2008-02-29 04:30:37, Chani Armitage wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/219/
> -----------------------------------------------------------
> 
> (Updated 2008-02-29 04:30:37)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> this is a fairly ugly patch.the idea was to remove the size entry from the panel config and magically calculate it from the geometry. right now it has one big bug: if there's no config file the size will default to 40 instead of 48, because of some magic somewhere else that makes the panel+border 40x48 at some point. I think that might maybe be solvable by having corona load containments' constraints before init instead of after. however, given how ugly my code is right now, I'm not sure whether it's worth finishing this patch, seeing as trunk will probably make it all unnecessary soon. should I keep working on it or go do something else?
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.h
>   /trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp
> 
> Diff: http://mattr.info/r/219/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chani
> 
>