Review Request: Kickoff: Better presentation
Stephan Binner
binner at kde.org
Fri Feb 22 09:38:45 CET 2008
> On 2008-02-21 16:45:56, Aaron Seigo wrote:
> > trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/itemdelegate.cpp, line 92
> > <http://mattr.info/r/178/diff/1/#file384line92>
> >
> > ' ' + subTitleText (avoid crazy complaining about " " when ' ' will do and spacing around the +)
That's more than one space in my patch.
> On 2008-02-21 16:45:56, Aaron Seigo wrote:
> > trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/itemdelegate.cpp, line 123
> > <http://mattr.info/r/178/diff/1/#file384line123>
> >
> > ' '
Here too more than one space character.
- Stephan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/178/#review170
-----------------------------------------------------------
On 2008-02-21 14:17:15, Stephan Binner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/178/
> -----------------------------------------------------------
>
> (Updated 2008-02-21 14:17:15)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> This patches changes several small things for a better presentation: sizes, indentation, selection, shown information...
>
>
> Diffs
> -----
>
> trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/flipscrollview.cpp
> trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/itemdelegate.h
> trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/itemdelegate.cpp
>
> Diff: http://mattr.info/r/178/diff
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> Screenshot
> http://mattr.info/r/178/s/16/
>
>
> Thanks,
>
> Stephan
>
>
More information about the Panel-devel
mailing list