Review Request: Kickoff: Better presentation

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info/r/178/#review170
-----------------------------------------------------------



trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/itemdelegate.cpp
<http://mattr.info/r/178/#comment117>

    = QString()



trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/itemdelegate.cpp
<http://mattr.info/r/178/#comment118>

    ' ' + subTitleText (avoid crazy complaining about " " when ' ' will do and spacing around the +)



trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/itemdelegate.cpp
<http://mattr.info/r/178/#comment120>

    this part is wrong. always showing all the text creates visual clutter that is simply unacceptable.
    
    it was completely purposeful that this decision was made for 4.0.
    
    we've been around this issue before, so i'm not sure why it keeps getting brought up ... but the real solution is to only show the subtext if the main text is duplicated in the previous item because that is the actual usability issue here.
    
    i'll make you a deal, leave this part of the patch out and i'll code the proper fix as soon as this is in. deal?



trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/itemdelegate.cpp
<http://mattr.info/r/178/#comment119>

    ' '


- Aaron


On 2008-02-21 14:17:15, Stephan Binner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info/r/178/
> -----------------------------------------------------------
> 
> (Updated 2008-02-21 14:17:15)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patches changes several small things for a better presentation: sizes, indentation, selection, shown information...
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/flipscrollview.cpp
>   trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/itemdelegate.h
>   trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/itemdelegate.cpp
> 
> Diff: http://mattr.info/r/178/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Screenshot
>   http://mattr.info/r/178/s/16/
> 
> 
> Thanks,
> 
> Stephan
> 
>