Review Request: Mission FixTwitter: Layouts Respecting Margins and TopLeft Offsets

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/112/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

This is monster patch that does the follow:

* moves the idea of margins up to LayoutItem, allowing any LayoutItem to have a margin (also setMargin -> setMargins)
* moves the idea of the size of the item up to LayoutItem, as both Widget and Layout implemented it separately
* provides a way in LayoutItem to adjust a rect within an item to its margins (that is what LayoutItem::topLeft() is there for)
* fix several bugs, both painting and sizing, in LineEdit
* Applet sets margins now based on the existence of setDrawBackground

this patch may, in theory, make the (0, 0) offset rendering unnecessary, though it would require instrumenting all non-layout using widgets to respect margins; so probably not worth it, but interesting to note.


Diffs
-----

  /trunk/KDE/kdebase/workspace/libs/plasma/applet.h
  /trunk/KDE/kdebase/workspace/libs/plasma/applet.cpp
  /trunk/KDE/kdebase/workspace/libs/plasma/containment.cpp
  /trunk/KDE/kdebase/workspace/libs/plasma/layouts/boxlayout.cpp
  /trunk/KDE/kdebase/workspace/libs/plasma/layouts/flowlayout.cpp
  /trunk/KDE/kdebase/workspace/libs/plasma/layouts/layout.h
  /trunk/KDE/kdebase/workspace/libs/plasma/layouts/layout.cpp
  /trunk/KDE/kdebase/workspace/libs/plasma/layouts/layoutitem.h
  /trunk/KDE/kdebase/workspace/libs/plasma/layouts/layoutitem.cpp
  /trunk/KDE/kdebase/workspace/libs/plasma/packages.cpp
  /trunk/KDE/kdebase/workspace/libs/plasma/widgets/lineedit.h
  /trunk/KDE/kdebase/workspace/libs/plasma/widgets/lineedit.cpp
  /trunk/KDE/kdebase/workspace/libs/plasma/widgets/widget.h
  /trunk/KDE/kdebase/workspace/libs/plasma/widgets/widget.cpp

Diff: http://matt.rogers.name/r/112/diff


Testing
-------

So far, tested with Twitter in plasmoidviewer and on desktop, with tasks on desktop and in panel, full plasma session ....


Thanks,

Aaron