Review Request: Fix crash when removing the twitter applet.

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/106/#review105
-----------------------------------------------------------

Ship it!


Looks good from here.

- Aaron


On 2008-02-11 04:39:04, Andre Duffeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/106/
> -----------------------------------------------------------
> 
> (Updated 2008-02-11 04:39:04)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Fix crash when removing the twitter applet.
> The problem was that the ElementAnimationStates in d->animatedElements where only removed in Phase::stopElementAnimation(AnimId id) until now and not when the animation was finished, so the QGraphicsItem was still referenced in further timerEvents.
> 
> Additionally, shouldn't we connect to the item's destroyed() signal, as it is done with customAnimations?
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/libs/plasma/phase.cpp
> 
> Diff: http://matt.rogers.name/r/106/diff
> 
> 
> Testing
> -------
> 
> Tested the twitter applet. Crash is gone, Plasma::Flash needs some adjustment though.
> 
> 
> Thanks,
> 
> Andre
> 
>