Review Request: Fix crash when removing the twitter applet.

Andre Duffeck duffeck at kde.org
Mon Feb 11 11:39:04 CET 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/106/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Fix crash when removing the twitter applet.
The problem was that the ElementAnimationStates in d->animatedElements where only removed in Phase::stopElementAnimation(AnimId id) until now and not when the animation was finished, so the QGraphicsItem was still referenced in further timerEvents.

Additionally, shouldn't we connect to the item's destroyed() signal, as it is done with customAnimations?


Diffs
-----

  trunk/KDE/kdebase/workspace/libs/plasma/phase.cpp

Diff: http://matt.rogers.name/r/106/diff


Testing
-------

Tested the twitter applet. Crash is gone, Plasma::Flash needs some adjustment though.


Thanks,

Andre



More information about the Panel-devel mailing list