Review Request: tooltip(and those who uses svgpanel): update margin sizes on theme changes
Marco Martin
notmart at gmail.com
Fri Feb 8 21:55:37 CET 2008
> On 2008-02-08 13:38:42, Aaron Seigo wrote:
> > this looks correct; will you go around and fix the other items as well? off the top of my head that would be the panel containment, applet and krunner/krunnerdialog.cpp
ok, done (tooltip, dialog, panel and krunnerdialog). for the applet uhm, it seems they are calculated every time in functions that use them like contentsize and not stored, so.. :)
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/94/#review85
-----------------------------------------------------------
On 2008-02-08 12:03:36, Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/94/
> -----------------------------------------------------------
>
> (Updated 2008-02-08 12:03:36)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> with this patch setContentsMargins() is called every time the theme changes, because the new svg could have different margins.
> at the moment it is in resetpalette(), if it's ok doing that i think that function should be renamed something like themeChanged()
> and i think it should be done pretty much on everything that uses a svg background.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/libs/plasma/widgets/tooltip.cpp
>
> Diff: http://matt.rogers.name/r/94/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco
>
>
More information about the Panel-devel
mailing list