Review Request: tooltip(and those who uses svgpanel): update margin sizes on theme changes

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/94/#review85
-----------------------------------------------------------

Ship it!


this looks correct; will you go around and fix the other items as well? off the top of my head that would be the panel containment, applet and krunner/krunnerdialog.cpp

- Aaron


On 2008-02-08 12:03:36, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/94/
> -----------------------------------------------------------
> 
> (Updated 2008-02-08 12:03:36)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> with this patch setContentsMargins() is called every time the theme changes, because the new svg could have different margins.
> at the moment it is in resetpalette(), if it's ok doing that i think that function should be renamed something like themeChanged()
> and i think it should be done pretty much on everything that uses a svg background.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/widgets/tooltip.cpp
> 
> Diff: http://matt.rogers.name/r/94/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>