Review Request: Configuration dialog for Cia.vc applet

[Henry de Valence]

> On 2008-02-06 21:13:04, Aaron Seigo wrote:
> > /trunk/playground/base/plasma/applets/cia.vc/ciavc.cpp, line 125
> > <http://matt.rogers.name/r/87/diff/1/#file190line125>
> >
> >     where does m_text get created?

m_text is created in init() on line 60.


> On 2008-02-06 21:13:04, Aaron Seigo wrote:
> > /trunk/playground/base/plasma/applets/cia.vc/ciavc.cpp, line 231
> > <http://matt.rogers.name/r/87/diff/1/#file190line231>
> >
> >     shouldn't this be a call to DataEngine::connectSource()?

I don't think so, because the sourceAdded function actually does a bunch of stuff.


- Henry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/87/#review73
-----------------------------------------------------------


On 2008-02-06 22:34:01, Henry de Valence wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/87/
> -----------------------------------------------------------
> 
> (Updated 2008-02-06 22:34:01)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Add configuration to the cia.vc applet so you can pick the project it shows
> 
> 
> Diffs
> -----
> 
>   /trunk/playground/base/plasma/applets/cia.vc/ciavc.h
>   /trunk/playground/base/plasma/applets/cia.vc/ciavc.cpp
> 
> Diff: http://matt.rogers.name/r/87/diff
> 
> 
> Testing
> -------
> 
> Compiled and tested a bunch of different feeds
> 
> 
> Thanks,
> 
> Henry
> 
>