Review Request: Configuration dialog for Cia.vc applet

Aaron Seigo aseigo at kde.org
Thu Feb 7 04:13:04 CET 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/87/#review73
-----------------------------------------------------------


yay, project changing! =) it becomes generally useful ;) there are some outstanding issues with the patch though i think, detailed below:



/trunk/playground/base/plasma/applets/cia.vc/ciavc.cpp
<http://matt.rogers.name/r/87/#comment60>

    shouldn't this be config() as it would be per-applet?



/trunk/playground/base/plasma/applets/cia.vc/ciavc.cpp
<http://matt.rogers.name/r/87/#comment61>

    ... making this rewritable as:
    
    m_project = cg.readEntry("project", "KDE");



/trunk/playground/base/plasma/applets/cia.vc/ciavc.cpp
<http://matt.rogers.name/r/87/#comment66>

    where does m_text get created?



/trunk/playground/base/plasma/applets/cia.vc/ciavc.cpp
<http://matt.rogers.name/r/87/#comment62>

    this isn't necessary if the settings are per-applet.



/trunk/playground/base/plasma/applets/cia.vc/ciavc.cpp
<http://matt.rogers.name/r/87/#comment65>

    do you want to call configNeedsSaving here as well?



/trunk/playground/base/plasma/applets/cia.vc/ciavc.cpp
<http://matt.rogers.name/r/87/#comment64>

    shouldn't this be a call to DataEngine::connectSource()?



/trunk/playground/base/plasma/applets/cia.vc/ciavc.cpp
<http://matt.rogers.name/r/87/#comment63>

    shouldn't this be a call to DataEngine::connectSource()?


- Aaron


On 2008-02-06 14:38:22, Henry de Valence wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/87/
> -----------------------------------------------------------
> 
> (Updated 2008-02-06 14:38:22)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> 
> Diffs
> -----
> 
>   /trunk/playground/base/plasma/applets/cia.vc/ciavc.h
>   /trunk/playground/base/plasma/applets/cia.vc/ciavc.cpp
> 
> Diff: http://matt.rogers.name/r/87/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Henry
> 
>



More information about the Panel-devel mailing list