Review Request: Convert from QUrl to KUrl in the kickoff applet.

[Bill Egert]

> On 2008-02-03 15:40:43, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/itemhandlers.cpp, line 48
> > <http://matt.rogers.name/r/50/diff/1/#file65line48>
> >
> >     KUrl::path() is not the same as QUrl::toString(). the latter preserves the whole url (e.g. the protocol) while the former just provides the path part of the URI. so this (and the entry on line 50 as well) should preserve the usage of toString()

for a KUrl toString is private so I had to use something else.  I originally tried url() as suggested in kurl.h, but that wasn't working.  I finally got it to start opening apps again using pathOrUrl() .  I then just put it to path() because I figured that seemed more appropriate.

I am open to suggestions :)


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/50/#review44
-----------------------------------------------------------


On 2008-02-03 09:07:26, Bill Egert wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/50/
> -----------------------------------------------------------
> 
> (Updated 2008-02-03 09:07:26)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Convert from QUrl to KUrl in the kickoff applet.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/itemhandlers.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/itemhandlers.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/leavemodel.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/models.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/urlitemlauncher.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/urlitemlauncher.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/simpleapplet/menuview.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/simpleapplet/simpleapplet.cpp
> 
> Diff: http://matt.rogers.name/r/50/diff
> 
> 
> Testing
> -------
> 
> -opened apps via kickoff.
> -cleared recent applications/documents.
> 
> 
> Thanks,
> 
> Bill
> 
>