Review Request: Convert from QUrl to KUrl in the kickoff applet.

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/50/#review44
-----------------------------------------------------------



/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/itemhandlers.cpp
<http://matt.rogers.name/r/50/#comment48>

    KUrl::path() is not the same as QUrl::toString(). the latter preserves the whole url (e.g. the protocol) while the former just provides the path part of the URI. so this (and the entry on line 50 as well) should preserve the usage of toString()


other than the above (and the previous comment, which already seems to be addressed), i'm happy with this patch.

- Aaron


On 2008-02-03 09:07:26, Bill Egert wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/50/
> -----------------------------------------------------------
> 
> (Updated 2008-02-03 09:07:26)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Convert from QUrl to KUrl in the kickoff applet.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/itemhandlers.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/itemhandlers.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/leavemodel.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/models.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/urlitemlauncher.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/urlitemlauncher.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/simpleapplet/menuview.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/simpleapplet/simpleapplet.cpp
> 
> Diff: http://matt.rogers.name/r/50/diff
> 
> 
> Testing
> -------
> 
> -opened apps via kickoff.
> -cleared recent applications/documents.
> 
> 
> Thanks,
> 
> Bill
> 
>