API review breakages

Aaron J. Seigo aseigo at kde.org
Thu Apr 24 16:04:55 CEST 2008


On Thursday 24 April 2008, Anne-Marie Mahfouf wrote:
> Hi,
>
> As you know, we're changing API following the Tokamak1 techbase page (1).
> We're doing our best to do that sanely:

you guys are rocking, btw =)

> Reviewing the API is 
> not a matter of blindly replacing strings by another string...

yes, it often takes a bit more thought.

> updateSource() is reimplemented in some engines (like the weather engine)
> and I did not fixe those as I fear I can even break further. It builds but
> Shawn said it's broken.

in this case a simple s,updateSource,updateSourceEvent, should be enough.

> Should I try getting deeper into that or should the engines maintainers be
> aware that they'll have to fix stuff as well?

as we go through and make the API changes, it's a good idea to keep extragear 
and kdebase up to speed as well.
 
> Would adding the svn revision on the techbase page help? (I'll do it if
> so).

it wouldn't hurt... but i doubt it would actually get used... 

if we do need it, it's easy to go through the commit log here (i have all the 
emails for plasma commits in a folder here =) and find relevant commits that 
way.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080424/9ed6a531/attachment.pgp 


More information about the Panel-devel mailing list