[REVIEW] Clock: respect font settings for date and timezone

[Sebastian Kuegler]

On Tuesday 15 April 2008 20:56:10 Rafał Miłecki wrote:
> This is about bug report http://bugs.kde.org/show_bug.cgi?id=157226
>
> Some explination:
>
> -        p->setFont(KGlobalSettings::smallestReadableFont());
> Removed because we set font every time before drawing text.
>
>
> -        m_plainClockFont.setBold(m_plainClockFontBold);
> -        m_plainClockFont.setItalic(m_plainClockFontItalic);
> We set that on init and after applying changes. Not needed to do that
> again.
>
>
> Any objections for commiting?

Thinking about this a bit more ... here's the problem why it was that way:

The smallestReadableFont settting is a font at a certain size, this size is 
only relevant to this very font so we cannot just set another font and use 
the size of smallestReadable font  -- it might not work with that one. Also, 
as the setting only goes about numbers, one could for example choose a font 
that works well with numbers, but doesn't with text. And, after all, the 
fonts on the desktop should be consistent.

So that bug really isn't one, it's just a misconception. The setting is not 
for the while applet, but for the clock only. The date and timezone setting 
comes from systemsetting smallestReadableFont. 

So I'm not so sure after all if we really want that, or if your patch should 
be reverted with the bug marked as WONTFIX or something.

Do you better suggestions how to solve that problem? IMO neither of the 
-- 
sebas

 http://www.kde.org | http://vizZzion.org |  GPG Key ID: 9119 0EF9 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 481 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080416/4c573784/attachment.pgp