[PATCH] Digital clock: little cleaning

[Sebastian Kuegler]

On Wednesday 09 April 2008 19:42:01 Rafał Miłecki wrote:
> 2008/4/9, Sebastian Kuegler <sebas at kde.org>:
> > ... had a  quick look at the patch, it looks good. How is|will the
> >  userinterface (be) done? How do you indicate the primary timezone?
>
> Inspired by KDE3 clock I wish to let user choose main time zone from
> all time zones he checked in KTimeZoneWidget and "Local" tz.
>
> There is mockup:
> http://sirius.cs.put.poznan.pl/~inf80100/clock.timezones.png
> Do you like this idea? Any objections?

The overall approach fine, but I think it has the problem that you cannot 
easily remove a certain timezone, you have to find it back in that looooooong 
list of timezones, means lots of scrolling to find and remove timezones. 
Adding a searchbox that filters the list would probably help, I wonder how 
elegant that is, though. Or maybe some display of active timezones with an 
easy way to remove them. I love the iphone interface for doing that, 
btw.*1 :)

*1) did someone say that we need extenders? :P

> >  patch doesn't change the UI, yet, right?
>
> Right

+    else {
+        kDebug() << "Oh, our avoiding code is usefully!";
+    }

Should not go in.

Otherwise, please commit it. :)
-- 
sebas

 http://www.kde.org | http://vizZzion.org |  GPG Key ID: 9119 0EF9 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 481 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080409/8c87fd7f/attachment-0001.pgp