[PATCH] Digital clock: little cleaning

Sebastian Kuegler sebas at kde.org
Wed Apr 9 18:40:55 CEST 2008


On Wednesday 09 April 2008 09:34:27 Rafał Miłecki wrote:
>  There is my second of three steps into multi time zones support in
>  digital clock. Can you review this, please? Do you agree me to commit
>  that?
>
>  1) I added exported some code to updateToolTipContent() because this
>  code will be also used by updateToolTip() - now I can just call this
>  new function
>  2) I added bool m_localTimeZone because in future there may be
>  situation when user will choose Local as *main* time zone, but user
>  will also want to see other time zones (in tooltip)
>  3) I moved m_prettyTimezone.replace("_", " "); to make code cleaner

... had a  quick look at the patch, it looks good. How is|will the 
userinterface (be) done? How do you indicate the primary timezone?

If noone else has comments, please commit and go ahead implementing it. This 
patch doesn't change the UI, yet, right?
-- 
sebas

 http://www.kde.org | http://vizZzion.org |  GPG Key ID: 9119 0EF9 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 481 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080409/cb92eb45/attachment.pgp 


More information about the Panel-devel mailing list