[PATCH] Digital clock: little cleaning

Rafał Miłecki zajec5 at gmail.com
Wed Apr 9 09:34:27 CEST 2008


---------- Forwarded message ----------
From: Rafał Miłecki <zajec5 at gmail.com>
Date: 08-04-2008 22:45
Subject: Ask for next review


Hi,

 There is my second of three steps into multi time zones support in
 digital clock. Can you review this, please? Do you agree me to commit
 that?

 1) I added exported some code to updateToolTipContent() because this
 code will be also used by updateToolTip() - now I can just call this
 new function
 2) I added bool m_localTimeZone because in future there may be
 situation when user will choose Local as *main* time zone, but user
 will also want to see other time zones (in tooltip)
 3) I moved m_prettyTimezone.replace("_", " "); to make code cleaner

--
Rafał Miłecki
-------------- next part --------------
A non-text attachment was scrubbed...
Name: digital.clock.cleaning.for.zones.patch
Type: application/octet-stream
Size: 5689 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080409/9f290dcf/attachment.obj 


More information about the Panel-devel mailing list