[Panel-devel] clock size regression

[Aaron J. Seigo]

On Wednesday 12 September 2007, Robert Knight wrote:
> > so, does anyone feel particularly responsible for breaking the ability
> > for the analog clock to change sizes? ;)
>
> Yes.  This is related to the layout changes.  Locally I fixed it and

i've gotten to the point where i don't even care anymore. just fix it.

i do wonder about this in the patch:

+        Qt::Orientations expandingDirections() const { return 0; }

it looks wrong in a few different ways.

and if you care at all about my ability to walk with a smile through all this, 
please stick to the coding style. i know playing "how many ways can we screw 
the code base" is fun and all, but let's at least try and keep some things 
sacred. eg:

+    if ( d->layout )
+        d->layout->addItem(applet);

is wrong on two counts.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20070912/282b9765/attachment-0001.pgp