[Panel-devel] clock size regression

[Robert Knight]

> so, does anyone feel particularly responsible for breaking the ability for the
> analog clock to change sizes? ;)

Yes.  This is related to the layout changes.  Locally I fixed it and
the same issue in Amarok using the suggestion that I aired in the
other applet-size thread, where applets on the desktop are managed by
a layout class which always gives applets whatever size they ask for
(via contentSizeHint() ) and does not position them in any particular
way.

Attached is my local patch against the Plasma library and the clock
applet.  The net number of lines of code that an applet needs to call
to change its size is unchanged from before.  Instead of calling
prepareGeometryChange() before any updates that affect the applet's
size, they now do the updates and then call updateGeometry().

Regards,
Robert.

On 13/09/2007, Aaron J. Seigo <aseigo at kde.org> wrote:
> hi...
>
> so, does anyone feel particularly responsible for breaking the ability for
> the
> analog clock to change sizes? ;)
>
> i'm thinking the most likely candidate are the setGeometry related changes..
> i'd prefer to work on other things than track down this regression, however,
> so if someone has an immediate idea where the problem might be, please be my
> guest...
>
> --
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Trolltech
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: plasma_clock_size_fix.patch
Type: text/x-diff
Size: 2373 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20070913/f8a5b025/attachment.bin