[Panel-devel] plasmagik and /tmp

[Aaron J. Seigo]

hi...

this is mostly for Andrea (adjam), but figure here is as good a place as any 
to discuss =) 

i noticed today a commit to plasmagik today that puts a directory in /tmp to 
be zipped up when creating a package. this has a few problems (besides 
leaking the new'd QDir on line 314) ... one can't assume /tmp is available 
for use like that.

at a minimum instead this code should be using KStandardDirs to locate the 
proper "tmp" resource dir. in fact, the best thing to do is to use KTempDir 
here. you also get cleanup for free in that case and protect against symlink 
attacks on the dir creation ...

hth..

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071011/4398e3cc/attachment-0001.pgp