[Panel-devel] Battery applet

[Sebastian Kügler]

On Monday 08 October 2007 17:50:42 Anne-Marie Mahfouf wrote:
> Again 2 very small fixes on the Battery but having not worked with
> FormFactor yet, I prefer having a bit of scrutiny from you guys (and gals).
>
> The first resize(m_size); removed is a consequence of calling yesterday's
> fixes on resize.

Thanks for that, btw.

> The update(); is needed line 136 so that the showString config is
> immediately updated on Apply or OK (was only done on hover) to show/hide
> the % string. The question is: is the updateGeometry(); still needed or is
> the patch ok?

Ok, good catch. The updateGeometry() is for size changes, I suppose that isn't 
enough when the size is not changed. The label should be updated when the 
dataengine has updated data, so in 'theory' this should be fine already. 
(Theory means that I'm probably overlooking something.)

Please commit.
-- 
sebas

 http://www.kde.org | http://vizZzion.org |  GPG Key ID: 9119 0EF9 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 481 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071008/fe72f6e7/attachment.pgp