[Panel-devel] Battery applet

Anne-Marie Mahfouf annemarie.mahfouf at free.fr
Mon Oct 8 17:50:42 CEST 2007


Hi,

Again 2 very small fixes on the Battery but having not worked with FormFactor 
yet, I prefer having a bit of scrutiny from you guys (and gals).

The first resize(m_size); removed is a consequence of calling yesterday's 
fixes on resize.

The update(); is needed line 136 so that the showString config is immediately 
updated on Apply or OK (was only done on hover) to show/hide the % string.
The question is: is the updateGeometry(); still needed or is the patch ok?

Anne-Marie


Index: battery.cpp
===================================================================
--- battery.cpp (revision 722777)
+++ battery.cpp (working copy)
@@ -108,7 +108,6 @@
         prepareGeometryChange();
         m_size = m_theme->size();
         m_font.setPointSize((int)(pixelSize/10));
-        resize(m_size);
         updateGeometry();
     }
 }
@@ -134,7 +133,7 @@
     } else {
         kDebug() << "Applet::Dunno what to do with " << source;
     }
-    updateGeometry();
+    update();
 }

 void Battery::showConfigurationInterface()



More information about the Panel-devel mailing list