[Panel-devel] trashcan applet

[Marco Martin]

On Nov 29, 2007 2:08 AM, Aaron J. Seigo <aseigo at kde.org> wrote:

> On Wednesday 28 November 2007, Marco Martin wrote:
> > Hi,
> > third patch...
> > in the update of yesterday i've seen more or less all the applets that
> used
> > plasma::Icon like the trashcan, the launcher and lock/logout seems to be
> > broken, only a little chunk of the icon is displayed, it's my build (uhm
> > updated and rebuilt everything two time for that :P) or it's "normal"?
>
> it's a bug. trying to track it down.. Plasma::Icon is pretty old code at
> this
> point and it's rather broken =/

it seems to be fixed if i explicitly put the icon into the layout like in
this patch, that i think it makes sense, even if i always have the feeling
that sizeHint of Icon doesn't work right


>
>
> > by the way in this patch i have more or less fixed the issue.
>
> through the setMinimumSize i take it.. yeah, that might actually need to
> go
> into the icon itself.
>
> > maybe tomorrow i will make a patch for the launcher, i would like to
> make
> > it like the trash applet (no background and text uner it), does it make
> > sense?
>
> it already has no background, text under it would be awesome. actually,
> the
> text under it needs to go into Plasma::Icon itself, really.

uhmmm, in the trash i use the setText method of the icon, that maybe should
be refinied a little bit (often impossible to read, maybe using a
drop-shadow?) but decining what the text is i think should be decided from
the applet, for example for the trash is trash and the number of items, for
the launcher i would say the filename part of the url or if it points to a
desktop file the name stored in it
maybe in the next few days i will see if i can understand something of the
icon class and if i am able to iron out some issues

>
>
> > and that of course doesn't work at all :) what is wrong?
>
> Plasma::Icon =/
>
> > one other thing. in the svn of today now clicking on open it seems to
> work,
> > but it opens konqueror insted of dolphin: it seems konqueror is still
> the
> > default for the inode/directory mimetype
>
> yep, known issue =/

weel, at least now it opens a file manager, the more is done :P

>
>
> --
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Trolltech
>
> _______________________________________________
> Panel-devel mailing list
> Panel-devel at kde.org
> https://mail.kde.org/mailman/listinfo/panel-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/panel-devel/attachments/20071129/ff8dbd13/attachment-0001.html