<br><br><div class="gmail_quote">On Nov 29, 2007 2:08 AM, Aaron J. Seigo <<a href="mailto:aseigo@kde.org">aseigo@kde.org</a>> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="Ih2E3d">On Wednesday 28 November 2007, Marco Martin wrote:<br>> Hi,<br>> third patch...<br>> in the update of yesterday i've seen more or less all the applets that used<br>> plasma::Icon like the trashcan, the launcher and lock/logout seems to be
<br>> broken, only a little chunk of the icon is displayed, it's my build (uhm<br>> updated and rebuilt everything two time for that :P) or it's "normal"?<br><br></div>it's a bug. trying to track it down.. Plasma::Icon is pretty old code at this
<br>point and it's rather broken =/</blockquote><div>it seems to be fixed if i explicitly put the icon into the layout like in this patch, that i think it makes sense, even if i always have the feeling that sizeHint of Icon doesn't work right
<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br><div class="Ih2E3d"><br>> by the way in this patch i have more or less fixed the issue.
<br><br></div>through the setMinimumSize i take it.. yeah, that might actually need to go<br>into the icon itself.<br><div class="Ih2E3d"><br>> maybe tomorrow i will make a patch for the launcher, i would like to make<br>
> it like the trash applet (no background and text uner it), does it make<br>> sense?<br><br></div>it already has no background, text under it would be awesome. actually, the<br>text under it needs to go into Plasma::Icon itself, really.
</blockquote><div>uhmmm, in the trash i use the setText method of the icon, that maybe should be refinied a little bit (often impossible to read, maybe using a drop-shadow?) but decining what the text is i think should be decided from the applet, for example for the trash is trash and the number of items, for the launcher i would say the filename part of the url or if it points to a desktop file the name stored in it
<br>maybe in the next few days i will see if i can understand something of the icon class and if i am able to iron out some issues<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br><div class="Ih2E3d"><br>> and that of course doesn't work at all :) what is wrong?<br><br></div>Plasma::Icon =/<br><div class="Ih2E3d"><br>> one other thing. in the svn of today now clicking on open it seems to work,
<br>> but it opens konqueror insted of dolphin: it seems konqueror is still the<br>> default for the inode/directory mimetype<br><br></div>yep, known issue =/</blockquote><div>weel, at least now it opens a file manager, the more is done :P
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br><div><div></div><div class="Wj3C7c"><br>--<br>Aaron J. Seigo<br>humru othro a kohnu se
<br>GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43<br><br>KDE core developer sponsored by Trolltech<br></div></div><br>_______________________________________________<br>Panel-devel mailing list<br><a href="mailto:Panel-devel@kde.org">
Panel-devel@kde.org</a><br><a href="https://mail.kde.org/mailman/listinfo/panel-devel" target="_blank">https://mail.kde.org/mailman/listinfo/panel-devel</a><br><br></blockquote></div><br>