[Panel-devel] KDE/kdebase/workspace/plasma

[Aaron J. Seigo]

On Sunday 17 June 2007, Riccardo Iaconelli wrote:
> SVN commit 676914 by ruphy:
>
> Adding a real wallpaper and use it in corona.
>
>
>  M  +1 -0      desktoptheme/CMakeLists.txt
>  M  +1 -1      plasma/coronaview.cpp
>
>
> --- trunk/KDE/kdebase/workspace/plasma/desktoptheme/CMakeLists.txt
> #676913:676914 @@ -9,6 +9,7 @@
>      widgets/toolbox-button.svg
>      widgets/plot-background.svg
>      widgets/iconbutton.svg
> +    widgets/wallpaper.svg
>      DESTINATION ${DATA_INSTALL_DIR}/desktoptheme/default/widgets/)
>
>  install(FILES
> --- trunk/KDE/kdebase/workspace/plasma/plasma/coronaview.cpp #676913:676914
> @@ -48,7 +48,7 @@
>      //kDebug() << "wallpaperPath is " << m_wallpaperPath << " " <<
> QFile::exists(m_wallpaperPath) << endl; if (m_wallpaperPath.isEmpty() ||
>          !QFile::exists(m_wallpaperPath)) {
> -        m_background = new Plasma::Svg("dialogs/background", this);
> +        m_background = new Plasma::Svg("widgets/wallpaper", this);
>      }
>  }

i almost regret making this small hack to allow loading of svg's (and now 
bitmaps) because people are modifying the code to continue this hack, which 
is not something we can ship, really.

we need a background renderer. it can be simple, but should have at least some 
of the features kdesktop had (i don't know if blending colours is really 
needed, tbh, and publishing the background via X is not needed -at all-; but 
caching, tiling and sizing are) plus at least one it didn't: multiple screens 
(well, we get that for "free" with corona, really, we just need configuration 
for it). making it pluggable would be awesome, with the default being this; 
it would allow more (or less) eye candy versions to be plugged in a swell.

that said, i'm not really wanting to go on about that too much ... what i 
really wanted to note is that if you are modifying the DesktopTheme you 
*must* do the following:

- first propose the change on panel-devel. i don't want it to be a dumping 
ground for random images, so let's work together on this.
- modify the Themes page at http://techbase.kde.org/Projects/Plasma/Theme to 
reflect the change
- modify the ThemePackage constructor in kdebase/workspace/plasma/packages.cpp 
appropriately

if you can't mange that last bit, we can find someone who can when the 
proposal is posted to the list.

thanks =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

Full time KDE developer sponsored by Trolltech (http://www.trolltech.com)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20070617/b29ab8bc/attachment.pgp