[Panel-devel] peer review your patches.

Aaron J. Seigo aseigo at kde.org
Sat Jul 21 03:45:26 CEST 2007


hi all...

it's great to see so many people actively hacking on things in plasma. 
however, if your code is going to touch something in libs/plasma or 
plasma/plasma/ and it isn't something amazingly obvious (e.g. a couple line 
fix or a crash prevention, etc..) i would appreciate it if you would have 
your patch peer reviewed before committing it.

this will help catch things like style violations, unecessary over-design and 
just general accidents and mistakes.

you can either have it peer reviewed by another plasma developer on irc or by 
posting it to the list here. if you do peer review on someone else's patch, 
please be tough on the patch. a bit of pedanticism today will save a lot of 
pain in the years to come.

thank you.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20070720/e7abf9e7/attachment.pgp 


More information about the Panel-devel mailing list