[Panel-devel] Plasma Tutorial

[Aaron J. Seigo]

On Sunday 08 July 2007, Bas Grolleman wrote:
> http://techbase.kde.org/User:Bgrolleman/Plasma/Tutorial

cool! =) nice to see this coming along ... some comments:

- as richard noted, the Plasma::Svg object should be a member of the class and 
instantiated in the constructor. in fact, i wouldn't make it a pointer at all 
(there's a memory leak in paintInterface =) but rather just a regular 
reference and intialize it in the constructor initialization list.

- please don't call it "background". there's already a method in 
Plasma::Applet to draw the -standard- background. so perhaps call it 
something else (showing how to draw SVGs is important, though =) and use 
setDrawStandardBackground(true) as well to show how that can be done.

- try and keep the lines of code shorter (e.g. by breaking them up over 
several lines where necessary) to get rid of the scollbars in the code 
examples

- i like the comments in the code =)

- including the contents of the CMakeLists.txt file needed to build the 
tutorial would be a good idea as well; it also helps make the 
K_EXPORT_PLASMA_APPLET bit make more sense =)

i think with those changes it could be put in the main tutorials section ..

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

Full time KDE developer sponsored by Trolltech (http://www.trolltech.com)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20070708/f3b45758/attachment.pgp