[Panel-devel] [PATCH] on icon resizing

[pinheiro]

A Friday 21 December 2007 21:15:46, Aaron J. Seigo escreveu:
> On Friday 21 December 2007, Marco Martin wrote:
> > ok, so removing calculatesize and setIconSize?
> > at the moment with the last patch the approach is intermediate between
> > the icon decides the size and the applet decides the size because the
> > aspect ratio changes upon resize, and i think it should be done in icon
> > widget rather thn in the icon applet because otherwise we will get ton of
> > identical duplicate code for every applet that uses an icon
>
> i think what is needed is a way to ask Plasma::Icon "if i want a 48px icon,
> how big do i have to make the whole thing?" and Plasma::Icon can return a
> suitable size that will make for a 48px icon with the current text, etc.
>
> but the applet (or layout) *must* be the ultimate controlling factor.
>
> > > - margins: not sure why this was added particularly, other than to make
> > > it work with icon views in Qt or whatever silly thing. but this gives
> > > rise to the problems that Craig is seeing. they should just be removed
> > > completely.
> >
> > uhm, no margins at all? wouldn't look ugly? (unless killing the
> > background svg)
>
> it wouldn't matter; the background svg should be just fine without an inner
> border.
>
> but yeah, i'm going to kill the background svg because, while i think it
> has great promise as a concept, we're really getting next to no attention
> from artists. they appear here and there now and again and it's just
> proving impossible to make it work with my schedule. they need a lot hand
> holding and have limited access to kde4 desktops. it's a really frustrating
> (and stupid) situation... but without decent art we have to forgoe some of
> these things. *sigh*

if you ask i will try to deliver..... like I normaly do... it may take some 
time, but normaly not that much....
but its important that people ask for the art, like the over efect on icons,,, 
i did those svg's long time ago like more than alf a year ago no one picked 
up...
I cant be all the time on #plasma irc is way to much time consuming and i need 
all the time i can get...  

> > > Marco: feel like doing such code amputations? =)
> >
> > ok, i will try after the resizing and the icon shadow issues are fixed
> > it's confusing enough to have two patches pending for the same file :D
>
> yeah.



-- 

core oxygen icon designer