[Panel-devel] Plasma::Icon highlighting issues

[Jason Stubbs]

On Friday 14 December 2007 00:32:04 Marco Martin wrote:
> On Thursday 13 December 2007, Jason Stubbs wrote:
> > The Kickoff changes (for both applet and simpleapplet) are:
> > * Display the menu on a click (=after release) rather than on mouse down
>
> Fixing Plasma::Icon is sweet, i tried so many times and never concluded
> anything:), my only concern is in this way it would be losen the
> possibility to start an application with one single click instead of two

Hmm.. I guess that's a valid use case. I've half-thrown in a immediateEvents() 
property that makes click() be emitted on the press event rather than a 
release event and seems to work fine while not breaking any of the other 
fixes.

This patch needs cleaning up but I need to be heading off the bed. ;)
If the addition of these two properties is fine, I'll clean up by getting rid 
of duplicated code and merge the properties into a QFlags.

Sound okay?

-- 
Jason Stubbs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: icon-highlighting.patch
Type: text/x-diff
Size: 12006 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071214/8d4f735b/attachment-0002.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kickoff-highlighting.patch
Type: text/x-diff
Size: 5185 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071214/8d4f735b/attachment-0003.bin