[Panel-devel] [PATCH] mousewheel on taskbar

[Marco Martin]

On Monday 10 December 2007, Aaron J. Seigo wrote:
> On Monday 10 December 2007, Marco Martin wrote:
> > On Sunday 09 December 2007, Marco Martin wrote:
> > > this patch compared to the previous one has the wheelevent
> > > reimplementation moved at the applet level, i think it's better because
> > > before if there will be a taskgroupitem inside another more than one
> > > would want to manage it.
> >
> > About this patch: can i commit or if not what it still needs to be
> > done/modified?
>
> heh.. you're faster than the others on this list who are able to peer
> review. =)

eh, today arrived te new shiny SVN account, so i was excited like a child :)
too bad the next 2 weeks i won't be able to do much :(

> this:
>
> bool operator ==(TaskEntry entry){return entry.task == task;}
>
> should probably be
>
> bool operator==(const TaskEntry &entry) const { return entry.task == task;
> }
>
> (note consts and use of whitespace =)
ok, done :)
> TaskGroupItem::cycle will behave oddly if _activeTask < 0. in particular,
> if _activeTask is -1 then this:
>
> _tasks[(_tasks.count() + _activeTask -1 )%_tasks.count()]
>
> will make it jump to _tasks.count() - 2, which is a bit odd. at least now
> it won't access something out of bounds of the array, which is good, and
> the forward movement in the no-active-task scenario activates the zeroth
> element, so that's also good.

since _activeTask=-1 is a special case, what about like in this patch where 
it's always activated the task 0?

> other 'n those two rather minor things, it looks good and ready for
> committing. =)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: tasks_6.diff
Type: text/x-diff
Size: 3645 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071210/d5692738/attachment-0001.bin