[Panel-devel] [PATCH] mousewheel on taskbar

[Aaron J. Seigo]

On Monday 10 December 2007, Marco Martin wrote:
> On Sunday 09 December 2007, Marco Martin wrote:
> > this patch compared to the previous one has the wheelevent
> > reimplementation moved at the applet level, i think it's better because
> > before if there will be a taskgroupitem inside another more than one
> > would want to manage it.
>
> About this patch: can i commit or if not what it still needs to be
> done/modified?

heh.. you're faster than the others on this list who are able to peer review. 
=)

this: 

bool operator ==(TaskEntry entry){return entry.task == task;}

should probably be

bool operator==(const TaskEntry &entry) const { return entry.task == task; }

(note consts and use of whitespace =)

TaskGroupItem::cycle will behave oddly if _activeTask < 0. in particular, if 
_activeTask is -1 then this:

_tasks[(_tasks.count() + _activeTask -1 )%_tasks.count()]

will make it jump to _tasks.count() - 2, which is a bit odd. at least now it 
won't access something out of bounds of the array, which is good, and the 
forward movement in the no-active-task scenario activates the zeroth element, 
so that's also good. 

other 'n those two rather minor things, it looks good and ready for 
committing. =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071210/93faabe9/attachment.pgp