[Panel-devel] KRunner history

[Ryan Bitanga]

On Dec 11, 2007 2:09 AM, Aaron J. Seigo <aseigo at kde.org> wrote:
> On Monday 10 December 2007, Ryan Bitanga wrote:
> > Is there any particular reason KRunner uses a plain KComboBox?
>
> probably due to not wanting to deal with the same annoyances that konqueror
> has had with its combobox[1]. i plopped this in as a quick hack to make
> people annoying me to stfu about the issue. one less gripe i had to deal with
> on a daily basis.
>
> > It currently has a bug wherein the items in the combobox keep on
> > getting appended to themselves. The call to m_searchTerm->addItems()
> > in resetInterface() should be preceded by a call to
> > m_searchTerm->clear() and followed by m_matchTimer.stop(). This patch
> > fixes that and uses KHistoryComboBox instead.
>
> other than the commented out code (just delete those lines =) it looks fine.
> you may wish to merge these two lines as well, or at least move them closer
> to each other:
>
> +    QStringList executions = cg.readEntry("pastqueries", QStringList());
> +    m_searchTerm->setHistoryItems(executions,true);
>
> up to you.
>
> oh, and please, please, please put spaces after commas =)
Oops. :)

>
> [1] http://bugs.kde.org/show_bug.cgi?id=153568#c5

So I take it I have the go signal to commit? It's apparently a kdelibs
bug and if we use KHistoryComboBox too, there's a bigger chance we'll
be able to fix the bugs and benefit other applications. :)

Ryan