[Panel-devel] KRunner history

[Aaron J. Seigo]

On Monday 10 December 2007, Ryan Bitanga wrote:
> Is there any particular reason KRunner uses a plain KComboBox?

probably due to not wanting to deal with the same annoyances that konqueror 
has had with its combobox[1]. i plopped this in as a quick hack to make 
people annoying me to stfu about the issue. one less gripe i had to deal with 
on a daily basis.

> It currently has a bug wherein the items in the combobox keep on
> getting appended to themselves. The call to m_searchTerm->addItems()
> in resetInterface() should be preceded by a call to
> m_searchTerm->clear() and followed by m_matchTimer.stop(). This patch
> fixes that and uses KHistoryComboBox instead.

other than the commented out code (just delete those lines =) it looks fine. 
you may wish to merge these two lines as well, or at least move them closer 
to each other:

+    QStringList executions = cg.readEntry("pastqueries", QStringList());
+    m_searchTerm->setHistoryItems(executions,true);

up to you. 

oh, and please, please, please put spaces after commas =)

[1] http://bugs.kde.org/show_bug.cgi?id=153568#c5

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071210/83633348/attachment.pgp