[Panel-devel] Svg::elementRect and theme configs

[Leo Franchi]

On 8/2/07, Aaron J. Seigo <aseigo at kde.org> wrote:
>
> On Wednesday 01 August 2007, Leo Franchi wrote:
> > Ok, i attach a new patch, plasma.svg.patch, that instead of "fixing"
> >  elementRect, exposes QSvgRenderer::matrixForElement to the client.
>
> looks fine, please commit this one.
>
> > Also, i attach a patch to fix the buggy patch applied in r695097. It is
>
> actually, this reverts the patch which was a pretty intentional change.
> what
> problem was this creating for you?


the problem is that with this patch the DataSource is never created
on-demand. In
dataengine.cpp, the DataContainer* s that connectSource tries to get is
never created, so the function returns early before actually connecting it.
if d->source is allowed to create the datasource, then it returns a valid
one, and everything works well. in essence, this breaks all the amarok
dataengines :P

also, i have  been running with this patch to kdebase and have noticed no
problems; what exactly was this line of the patch supposed to fix?

leo

> --
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Trolltech
>
> _______________________________________________
> Panel-devel mailing list
> Panel-devel at kde.org
> https://mail.kde.org/mailman/listinfo/panel-devel
>
>
>


-- 
______________________________________________________
Leo Franchi                    angel666 at myrealbox.com
4305 Charlemagne Ct         lfranchi at gmail.com
Austin                                 cell: (650) 704 3680
TX, USA                              home: (650) 329 0125
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/panel-devel/attachments/20070802/3c7c222c/attachment.html