<br><br><div><span class="gmail_quote">On 8/2/07, <b class="gmail_sendername">Aaron J. Seigo</b> <<a href="mailto:aseigo@kde.org">aseigo@kde.org</a>> wrote:</span><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
On Wednesday 01 August 2007, Leo Franchi wrote:<br>> Ok, i attach a new patch, plasma.svg.patch, that instead of "fixing"<br>> elementRect, exposes QSvgRenderer::matrixForElement to the client.<br><br>looks fine, please commit this one.
<br><br>> Also, i attach a patch to fix the buggy patch applied in r695097. It is<br><br>actually, this reverts the patch which was a pretty intentional change. what<br>problem was this creating for you?</blockquote><div>
<br>the problem is that with this patch the DataSource is never created on-demand. In dataengine.cpp, the DataContainer* s that connectSource tries to get is never created, so the function returns early before actually connecting it. if d->source is allowed to create the datasource, then it returns a valid one, and everything works well. in essence, this breaks all the amarok dataengines :P
<br><br>also, i have been running with this patch to kdebase and have noticed no problems; what exactly was this line of the patch supposed to fix?<br></div><br>leo<br><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
--<br>Aaron J. Seigo<br>humru othro a kohnu se<br>GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43<br><br>KDE core developer sponsored by Trolltech<br><br>_______________________________________________
<br>Panel-devel mailing list<br><a href="mailto:Panel-devel@kde.org">Panel-devel@kde.org</a><br><a href="https://mail.kde.org/mailman/listinfo/panel-devel">https://mail.kde.org/mailman/listinfo/panel-devel</a><br><br><br>
</blockquote></div><br><br clear="all"><br>-- <br>______________________________________________________<br>Leo Franchi <a href="mailto:angel666@myrealbox.com">angel666@myrealbox.com</a><br>4305 Charlemagne Ct
<a href="mailto:lfranchi@gmail.com">lfranchi@gmail.com</a> <br>Austin cell: (650) 704 3680<br>TX, USA home: (650) 329 0125