[Panel-devel] Some KDE4 portery...
Aaron J. Seigo
aseigo at kde.org
Thu Jun 30 20:30:58 CEST 2005
On Thursday 30 June 2005 08:23, Maks Orlovich wrote:
> Attached gets libkicker building, and kicker/* much further along, with
> just a few errors.
cool.. some feedback:
the #include <qptrdict.h> in kicker/core/pluginmanager.h isn't actually needed
at all. it can just be removed. i've done so in the 3.4 branch locally and
will commit momentarily.
userrectsel: i'm not so worried about the XorROP. i think that effect is fugly
in the exreme and i'm really not so happy about how panel DnD works in
general. and userrectsel is such a bad name it's just begging to be replaced
by something better anyways ;)
kicker/core/kicker.cpp: screw the global tooltip setting. let's just get rid
of that altogether. that was actually something i/we decided on irc a couple
months ago =)
there's this warning: #warning "Type looks bogus" .. what do you mean by that?
PopupMenuTitle: i think this is fine to remove. we'll probably end up doing
something nicer at some point for kde4 anyways.
kicker/ui/browser_mnu.cpp: //### KDE4: not needed? --> yep! =)
kicker/ui/client_mnu.cpp: dataStream.setVersion( QDataStream::Qt_3_1 ); <--
why setting it to QT_3_1? is dcop still using that marshalling?
otherwise, looks good as the first step. next would be to get everything else
compiling and then attacking all the Q3* classes. i'm really concerned that
3.4 branch hasn't been merged yet though as i can see this patch making it a
HUGE bitch to do that.
--
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20050630/b7cbccbb/attachment.pgp
More information about the Panel-devel
mailing list