[Panel-devel] Patch for KickerTip
Aaron J. Seigo
aseigo at kde.org
Fri Jun 3 16:31:42 CEST 2005
On Friday 03 June 2005 01:40, Martin Raum wrote:
> Just move the function updateData() from protected: (it should be in
then the Client will need to check if the tip is currently showing and if it
is tipping for that Client. the Client should be able to call updateDate()
(or whatever) whenever it feels like without having to worry about those
details. that was the entire point of my earlier patch, really =)
btw, this doesn't look correct either:
+bool KickerTip::isReasonable()
+{
+ return true;
in any case, i'm a big fan of simplicity. the patch you coded up is nice and
detailed, but i'm not sure the extra data members and code really provide
something useful over a simply Client::update() method. so enlighten me as to
the benefits of this patch, e.g. real use cases for timed updates, otherwise
i'd like to stick with simplicity.
--
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20050603/6cccb00d/attachment.pgp
More information about the Panel-devel
mailing list